Repository navigation
General bugfixes - #369
Merged
Merged
General bugfixes#369
Conversation
- UserDeposit: the item list may not name the same item twice. Each entry became its own stack in the vault, but the player lost the items only once, so stacks could be doubled. - UserCounterOffer: cancel the offer when an item is not held. The offer items were already cleared and the other player could still accept the old offer and get nothing. CleanupCancelOffer also resets PFLAG2_OFFER_OTHER_ACPT. - BP_CHANGE_DESCRIPTION: same MAX_CHAR_DESCRIPTION_LEN check as at character creation. A longer description overflowed the message buffer of the classic client when looking at the player. - GameDMCommand: go/get player only accept the decimal id of an existing object. The text was put into an admin command as is, so a modified client could add any message to it.
- LootChest: leftovers stay in the chest and every reset adds 30 to 50 new items, so the chest grew until the client crashed when opening it. It now keeps at most viMaxNumEntries (100) entries, the oldest go first. - Classic client who dialog: the list box pointed into the user list, which is freed when a new list arrives (e.g. after a garbage collection) or the game closes. The dialog now gets the new list first. - Classic client CheckServerMessage: never write past MAXMESSAGE. Long %q strings from the server overflowed the caller's buffer. - Delete() now also deletes these timers, so they can't fire on another object after the ids are renumbered by a garbage collection: Battler ptMinionControlCheck, Follower ptChat, RiijaMonk ptWorthyTimer, Player ptCanPhaseTimer, ptDeathRiftTimer, ptFactionTimer, ptLeaveBuilderGroupTimer, ptPhaseTimer, ptPhaseVisualEffectTimer, Admin ptTour, GuildHall ptEntrance (moved from GuildHall5, which now deletes its ptSecret), ChaosNight ptChaosNightEnd, LoginEvent ptEventEnd.
- NewOwner: PFLAG2_CHEAP_DEATH was checked in piFlags instead of piFlags2, so the flag from the lich queen's death was never cleared and the player had no death penalty from then on. - Spell: the darkness spellpower for Qor spells was rebuilt as -(state - 25), but the state is -(spellpower + 25). - SummonApparition CanPayCosts: return FALSE after the fizzle message for an empty target list. - HeartStone NewOwner: check for a nil owner before IsClass.
- Bless intro: missing space before "combat abilities". - Shatterlock safety: "you will marked" -> "you will be marked". - "Gewandheit" -> "Gewandtheit" in the German stat name, the agility boon texts and the character creation and stats dialogs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of small, independent bugfixes. Split into four commits by topic, each commit message has the details.
Exploits and abuse
Crashes
Logic
Texts