Skip to content

General bugfixes - #369

Merged
skittles1 merged 4 commits into
OpenMeridian105:developfrom
Arantis:general-bugfixes
Nov 5, 2026
Merged

skittles1 merged 4 commits into
OpenMeridian105:developfrom
Arantis:general-bugfixes

Conversation

@Arantis

@Arantis Arantis commented Nov 5, 2026

Copy link
Copy Markdown

A collection of small, independent bugfixes. Split into four commits by topic, each commit message has the details.

Exploits and abuse

  • Vault: a deposit list could name the same item twice, which doubled stacks.
  • Trade: a counter-offer with an item the player doesn't hold now cancels the trade. Before, the other player could accept the old offer and get nothing.
  • Character description: same length limit as at character creation. Longer descriptions overflowed the classic client's message buffer when looking at the player.
  • DM go/get player: only the decimal id of an existing object is accepted, because the text went into an admin command as is.

Crashes

  • Loot chests grew on every reset until the client crashed when opening them. They now keep at most 100 entries and the oldest go first.
  • Classic client who dialog: the list was freed while the dialog still pointed to it.
  • Classic client: message formatting can no longer write past the buffer.
  • Delete() now removes more timers, so they can't fire on another object after a garbage collection renumbers ids.

Logic

  • Cheap death: the flag was checked in piFlags instead of piFlags2, so it was never cleared after the lich queen's death and the player had no death penalty from then on.
  • Darkness bonus for Qor spells: the spellpower was rebuilt with the wrong sign. This is a small gameplay change: the bonus is 5 lower for players whose karma bonus doesn't already reach the secondary bonus limit of 10.
  • Summon Apparition: return FALSE after the fizzle message.
  • HeartStone: nil check on the new owner.

Texts

  • Missing word/space in the Bless and Shatterlock texts.
  • German: "Gewandheit" -> "Gewandtheit", also in the classic client dialogs, plus one grammar fix.

- UserDeposit: the item list may not name the same item twice. Each entry
  became its own stack in the vault, but the player lost the items only
  once, so stacks could be doubled.
- UserCounterOffer: cancel the offer when an item is not held. The offer
  items were already cleared and the other player could still accept the
  old offer and get nothing. CleanupCancelOffer also resets
  PFLAG2_OFFER_OTHER_ACPT.
- BP_CHANGE_DESCRIPTION: same MAX_CHAR_DESCRIPTION_LEN check as at
  character creation. A longer description overflowed the message buffer
  of the classic client when looking at the player.
- GameDMCommand: go/get player only accept the decimal id of an existing
  object. The text was put into an admin command as is, so a modified
  client could add any message to it.
- LootChest: leftovers stay in the chest and every reset adds 30 to 50
  new items, so the chest grew until the client crashed when opening it.
  It now keeps at most viMaxNumEntries (100) entries, the oldest go first.
- Classic client who dialog: the list box pointed into the user list,
  which is freed when a new list arrives (e.g. after a garbage collection)
  or the game closes. The dialog now gets the new list first.
- Classic client CheckServerMessage: never write past MAXMESSAGE. Long
  %q strings from the server overflowed the caller's buffer.
- Delete() now also deletes these timers, so they can't fire on another
  object after the ids are renumbered by a garbage collection:
  Battler ptMinionControlCheck, Follower ptChat, RiijaMonk
  ptWorthyTimer, Player ptCanPhaseTimer, ptDeathRiftTimer,
  ptFactionTimer, ptLeaveBuilderGroupTimer, ptPhaseTimer,
  ptPhaseVisualEffectTimer, Admin ptTour, GuildHall ptEntrance (moved
  from GuildHall5, which now deletes its ptSecret), ChaosNight
  ptChaosNightEnd, LoginEvent ptEventEnd.
- NewOwner: PFLAG2_CHEAP_DEATH was checked in piFlags instead of
  piFlags2, so the flag from the lich queen's death was never cleared and
  the player had no death penalty from then on.
- Spell: the darkness spellpower for Qor spells was rebuilt as
  -(state - 25), but the state is -(spellpower + 25).
- SummonApparition CanPayCosts: return FALSE after the fizzle message
  for an empty target list.
- HeartStone NewOwner: check for a nil owner before IsClass.
- Bless intro: missing space before "combat abilities".
- Shatterlock safety: "you will marked" -> "you will be marked".
- "Gewandheit" -> "Gewandtheit" in the German stat name, the agility boon
  texts and the character creation and stats dialogs.
@skittles1 skittles1 added this to the 3.0.8 milestone Nov 5, 2026
@skittles1
skittles1 merged commit 3d6551e into OpenMeridian105:develop Nov 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants