fix(utils): guard null in checkAndFixMas + removeTrailingZeroes#10
Open
gpitel wants to merge 1 commit into
Open
fix(utils): guard null in checkAndFixMas + removeTrailingZeroes#10gpitel wants to merge 1 commit into
gpitel wants to merge 1 commit into
Conversation
Two pre-existing null-handling gaps surfaced by real designs: - checkAndFixMas: a just-added winding can leave a null excitation; skip null entries instead of dereferencing exc.current (crashed WireInfo/BasicCoreSelector on mount, making wire config unusable). - removeTrailingZeroes: null/undefined slip past isNaN()/isFinite(), then value.toFixed() throws; return early for null (crashed WaveformOutput render, so the Operating Point view failed to render). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing null-handling gaps in
assets/js/utils.js, both surfaced by real designs:checkAndFixMas— a just-added winding can leave anullexcitation inexcitationsPerWinding. The signal loop then dereferencesexc[signal]and throws, which crashedWireInfo/BasicCoreSelectoron mount and made the wire-configuration step unusable. Skip null entries.removeTrailingZeroes—null/undefinedslip pastisNaN()/isFinite(), thenvalue.toFixed()throws. This crashedWaveformOutputrendering, so the Operating Point view failed to render. Return early for null.Change
Minimal, defensive, no behavior change for valid inputs. +2/−1.
🤖 Generated with Claude Code