feat: Add AMD FSR 1.0 Upscaling & Fix Alert Bug - #17
Merged
Conversation
Wei-1
reviewed
May 21, 2026
Wei-1
left a comment
Wei-1
left a comment
Member
There was a problem hiding this comment.
I will actually test the PR this weekend. Here are some question when I go through the code for now though.
Wei-1
approved these changes
May 22, 2026
Wei-1
left a comment
Wei-1
left a comment
Member
There was a problem hiding this comment.
Tested the Code, has 2 comments
But should be fine in most cases though!
Will merge after adjustment!
| ppQuad = new THREE.Mesh(new THREE.PlaneGeometry(2, 2), material); | ||
| ppScene.add(ppQuad); | ||
|
|
||
| if (useFSR) { |
Member
There was a problem hiding this comment.
How about we add typeof setupFSR === "function" && here?
Can handle if fsr.js is not loaded correctly.
| renderer.outputEncoding = THREE.sRGBEncoding; | ||
| renderer.render(ppScene, ppCamera); | ||
|
|
||
| if (useFSR) { |
Member
There was a problem hiding this comment.
How about also add typeof setupFSR === "function" && here?
Can handle if fsr.js is not loaded correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented AMD FidelityFX Super Resolution (FSR 1.0) to improve performance on low-end hardware without sacrificing visual quality. Also includes a bug fix for the performance alert tooltip.
Changes
RawShaderMaterial.UPSCALING_PRESETandFSR_SHARPNESSto rendering settings. Automatically hides native resolution slider when a preset is active.rgbaalpha pass-through in FSR shaders to ensure OBS transparency does not render as a black background.updatePostProcessingSize()to scale FSR intermediate render targets correctly on window resize.raiseAlert()where checking an undefinedHAND_TRACKINGvariable caused the performance warning box to render empty text during Heavy/Upper-Body tracking.Testing