Conversation
Signed-off-by: David Leong <leongdl@amazon.com>
crowecawcaw
approved these changes
Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expr1.1--function-call-expr.yamlis a valid-template fixture, but with its own defaults it can't create a job.Ydefaults to3.7, and the fixture calls{{ int(Param.Y) }}. RFC 0006 says that call is an error: "If the value cannot be nondestructively converted, it's an error. E.g.int(3.75)is an error, the functionsfloor,ceil, androundare for this case."This change replaces that line with
{{ int(float(Param.X)) }}, which still exercisesint()on a FLOAT, now with a whole-number value (5.0→5). Thefloor/ceil/roundlines already coverParam.Y, so its3.7default stays.Why CI didn't catch it
run_openjd_cli_tests.pyjudgesjob_templates/withopenjd checkalone, which doesn't evaluate expressions against parameter defaults. openjd-model 0.10.0 (openjd-rs#407) reports every evaluation error at job creation, so any implementation that instantiates a job from this template now rejects it:openjd checkopenjd summaryCannot convert 3.7 to int: not a whole numberopenjd run --step Step15for the new lineThis was found by a service conformance harness that submits every valid
job_templates/fixture through job creation.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.