Skip to content

Add test report on PR#150

Closed
mgaffigan wants to merge 1 commit into
OpenIntegrationEngine:mainfrom
mgaffigan:maint/check-tests
Closed

Add test report on PR#150
mgaffigan wants to merge 1 commit into
OpenIntegrationEngine:mainfrom
mgaffigan:maint/check-tests

Conversation

@mgaffigan

Copy link
Copy Markdown
Contributor

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@kpalang
kpalang requested review from a team, gibson9583, jonbartels, kayyagari and tonygermano and removed request for a team August 1, 2025 12:00

@jonbartels jonbartels left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling my approval pending discussion in Discord about repo permissions.

@mgaffigan
mgaffigan marked this pull request as draft August 11, 2025 19:28
@mgaffigan

Copy link
Copy Markdown
Contributor Author

2025-07-26 22:15:44 +0000 - publish - INFO - This action is running on a pull_request event for a fork repository. Pull request comments and check runs cannot be created, so disabling these features. To fully run the action on fork repository pull requests, see https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.20.0/README.md#support-fork-repositories-and-dependabot-branches

@tonygermano identified an issue with PR's coming from contributors without write access. Converting to draft till that can be fixed.

@mgaffigan

mgaffigan commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

I'm re-submitting this for review. I think Tony's concern needs to be addressed, but I don't think the current state of the PR moves us in the wrong direction. As is, the PR adds test reports for anyone with write access. Further work is required to expand that for all contributors, but I don't think there is a reason to delay merge.

I suggest Tony's issue be opened separately for follow-on work, assuming this merges.

@mgaffigan
mgaffigan marked this pull request as ready for review September 29, 2025 04:43
@mgaffigan
mgaffigan marked this pull request as draft December 1, 2025 15:11
@tonygermano

Copy link
Copy Markdown
Member

Closed with merge of #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] GH Pipelines does not indicate on failed test run

5 participants