Skip to content

add docs for configuring webhook responses for Sync triggers#765

Merged
josephjclark merged 4 commits into
mainfrom
configurable-webhook-responses
May 19, 2026
Merged

add docs for configuring webhook responses for Sync triggers#765
josephjclark merged 4 commits into
mainfrom
configurable-webhook-responses

Conversation

@midigofrank
Copy link
Copy Markdown
Contributor

@midigofrank midigofrank commented Apr 28, 2026

Short Description

add docs for configuring webhook responses for Sync triggers

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@midigofrank midigofrank force-pushed the configurable-webhook-responses branch from 15586b2 to 23fd97b Compare May 15, 2026 15:32
@midigofrank midigofrank marked this pull request as ready for review May 18, 2026 13:37
@midigofrank midigofrank requested a review from josephjclark May 18, 2026 13:38
Copy link
Copy Markdown
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, just a couple of comments

Comment thread docs/build/triggers.md Outdated
system in one of two ways, depending on how the trigger is configured.

### **Asynchronous mode**
### **Async (Before Start)**
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're getting at, but can I recommend the title is Async Mode Responds Before Start

Just because the raw option text doesn't really have enough context to make this make sense

Comment thread docs/build/triggers.md
- Body: the final run state as a JSON object

**What this response includes:**
:::note Security policy for failed runs
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Comment thread docs/build/triggers.md Outdated
}
}
```
In sync mode you can set custom HTTP status codes via the trigger inspector
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "trigger inspector" clear? Do we use that language elsehwere?

Is it better to just say "set custom HTTP status codes on the trigger" ? That sort of covers the UI and CLI

Comment thread docs/build/triggers.md Outdated
}));
```

`webhookResponse` is captured from each step as it completes, with **last write
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit too technical. Although this might not be technically accurate, I think I'd say:

At the end of the run, the value of `state.webhookResponse` will be used to send the HTTP response back to the caller. Changing the value during the run does not affect the response: it's only the final state that counts.

@josephjclark josephjclark merged commit e2a1768 into main May 19, 2026
1 check passed
@josephjclark josephjclark deleted the configurable-webhook-responses branch May 19, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants