Repository navigation
Conversation
b09cc7d to
e7efa34
Compare
|
Automated review of This PR rewrites the NOVTAU catalogue: about 1,200 files, with many variants deleted and new colours and product lines added. The PR is not ready to merge as is: the removed colours have no per-entry reason and no moved_from links.
claude-haiku-5-5 · $0.08
Auto-merge: held back: E7 data/novtau/PETG/petg_sparkle/blue/sizes.json is removed, renamed or re-moded; E9 89 removal(s) or structural change(s) need a maintainer, e.g. Maintainers: ✅ LGTM & merge · workflow run |
|
Updated so every existing NOVTAU entity keeps its UUID, and renamed colours keep theirs as well. The 67 UUIDs still reported are colours and lines we have discontinued and replaced in the 2026 catalogue, so there is no successor to redirect them to. Could a maintainer apply the |
| "traits": { | ||
| "contains_wood": true | ||
| } | ||
| }, | ||
| "uuid": "a190bc59-eebe-42a7-a626-d9ee39f0714a" |
There was a problem hiding this comment.
🔴 The UUID was replaced with a new one. UUIDs must stay the same once merged, so restore the original value and keep your other edits. (AI opinion)
| "#5EC8DA", | ||
| "#6BDBCC" | ||
| ], | ||
| "color_hex": "#68D1CF", |
There was a problem hiding this comment.
🟡 This spool previously listed two colours and now has one. Keep every colour as an array, for example the original two plus any new ones. (AI opinion)
|
@JongLeeP please look into and fix the issues raised by the robot before we can merge. |
|
Both robot items are fixed in 29a929a:
The remaining UUID report covers colours and lines discontinued in the 2026 catalogue, with no successor to redirect to; those were described in the earlier note. Happy to adjust anything else the review flags. |
|
One more push since that comment: the two robot items are fixed and the |
|
Is there a specific source on why you need to delete these files without having moved_from? |
|
Good catch — there is no reason to delete them. Those entries were retired 2025 lines/colours ( Restored all of them in 9b88208 with |
| "#93A3E6", | ||
| "#A188CB" | ||
| ], | ||
| "color_hex": "#A5A7E9", |
There was a problem hiding this comment.
🔴 This multi-colour spool went from two colours to one ("#A5A7E9"). Keep every colour in the array, as the previous version did, instead of shrinking it to a single value. (AI opinion)
| "#EC9087", | ||
| "#F0A875" | ||
| ], | ||
| "color_hex": "#F3A688", |
There was a problem hiding this comment.
🔴 The colour array went from two colours to one. Restore both colours as an array; multi-colour spools must keep every colour. (AI opinion)
| "#F5D991", | ||
| "#92CCDD" | ||
| ], | ||
| "color_hex": "#E0C8A0", |
There was a problem hiding this comment.
🔴 The colour array went from three colours to one. Restore all three colours as an array. (AI opinion)
| { | ||
| "id": "glow_rainbow_crystal", | ||
| "name": "Glow Rainbow Crystal", | ||
| "color_hex": "#C4B89A", |
There was a problem hiding this comment.
🟡 'Glow Rainbow Crystal' is a multi-colour filament but color_hex holds one value. Give an array with every colour on the spool. (AI opinion)
| { | ||
| "id": "crystal_rainbow_pink", | ||
| "name": "Crystal Rainbow Pink", | ||
| "color_hex": "#F6A9AE", |
There was a problem hiding this comment.
🟡 'Crystal Rainbow Pink' is multi-colour, but color_hex holds a single colour. Use an array with every colour on the spool. (AI opinion)
| { | ||
| "id": "dual_purple_green_to_pink_yellow", | ||
| "name": "Dual Purple-Green to Pink-Yellow", | ||
| "color_hex": "#EEB78A", |
There was a problem hiding this comment.
🟡 This dual-colour variant needs color_hex as an array of both colours, not one value. (AI opinion)
| { | ||
| "id": "white_glow_rainbow", | ||
| "name": "White Glow Rainbow", | ||
| "color_hex": "#C2BBA0", |
There was a problem hiding this comment.
🟡 'White Glow Rainbow' is multi-colour but color_hex holds one colour. Use an array with every colour on the spool. (AI opinion)
|
Please look at the AI feedback regarding colour changes, if a filament has multiple colours it should be using the array notation. |
| "traits": { | ||
| "glitter": true | ||
| }, | ||
| "uuid": "866b170d-d829-4ecb-a9e6-01b7320a214e" |
There was a problem hiding this comment.
🟡 The old PETG Sparkle Blue, Green and Red variants (petg_sparkle/blue, /green, /red) are deleted and replaced by sparkle_blue, sparkle_green and sparkle_red with new UUIDs. If this is a rename, add the old UUIDs to moved_from on the new variant.json files; otherwise state that these colours were retired and new ones added. (AI opinion)
| "container_hole_diameter": 54 | ||
| "container_hole_diameter": 54, | ||
| "container_width": 66, | ||
| "uuid": "6ee22158-32a8-4a3c-b979-a546401ecae9" |
There was a problem hiding this comment.
🔵 The new sparkle size rows also carry new UUIDs. Once the rename is confirmed, the spool-level UUIDs need the same moved_from treatment. (AI opinion)
|
Updated in
|
This updates the NOVTAU entries to match our 2026 product catalogue and website: 9 more product lines, colour names and codes aligned with the catalogue, and retired colours removed. Hex values are sampled from the catalogue swatch image of each colour, using the same method as the original PR. Happy to adjust anything.