Regenerate BD spinning-linearization baselines for the RotStates rotating-frame fix (openfast#3400)#184
Open
mayankchetan wants to merge 1 commit into
Open
Conversation
…ting-frame fix New baselines for the three spinning BeamDyn linearization cases, generated with openfast built from f/bd-rotstates-framefix (OpenFAST/openfast PR #3396, fixes issue #3394): with RotStates=True the exported BD state Jacobians are now expressed in a frame consistent with their RotatingFrame=T metadata, so the rotating-case .lin matrices change by design (the fix working). Standstill linearization output is bit-identical to the previous binary, so Damped_Beam, Damped_Beam_Fixed, and Damped_Beam_Rotated baselines are unchanged, as are all CompElast=1 cases. Only .lin files are regenerated (of_regression_linear compares .lin only); time-series .outb baselines are untouched (time marching is byte-identical in the paired openfast change). Generated on macOS arm64, gfortran, RelWithDebInfo, double precision. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CyaECKUrqvcsDCu78FAXi1
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to OpenFAST/openfast#3400 (fixes OpenFAST/openfast#3394). With
RotStates = True, BeamDyn now exports its state Jacobians in a frame that agreeswith their
RotatingFrame = Tmetadata. The.linbaselines of the threespinning BD linearization cases therefore change by design. The change is the fix.
Regenerated (17
.linfiles, nothing else):5MW_Land_BD_Linear5MW_Land_BD_Linear_AeroDamped_Beam_RotatingNot regenerated, by design:
Damped_Beam,Damped_Beam_Fixed,Damped_Beam_Rotated— standstill cases. Thetransform is the identity at zero rotor speed. The patched binary's standstill
.linoutput is bit-identical to the unpatched output.CompElast = 1cases — this code path is unaffected..outbtime-series baselines — time marching is byte-identical in the pairedopenfast change. The transform applies only at linearization snapshots.
Physics sanity check on the regenerated
5MW_Land_BD_Linear(12.1 rpm): the MBC3tower side-side frequency rises 0.3087 → 0.3152 Hz (+2.1 %). This matches the
removal of the spurious spin-softening (
f² = f₀² − αΩ², α ≈ 0.117 → ≈ 0) at thatrotor speed. Tower fore-aft moves only −0.4 % (its spurious α is ~0.007).
OpenFAST/openfast#3400 documents the full verification: a 0–25 rpm NREL 5-MW
acceptance sweep, and a 29-case IEA fleet against an independent python reference.
This branch is rebased onto r-test
rc-5.0.1to match the openfast PR base.Baselines were generated on macOS arm64, gfortran, RelWithDebInfo, double
precision, with the fix branch
f/bd-rotstates-framefix.