[UI] Enable strict TypeScript checking for date-picker popover - #3976
sfeilmeier merged 3 commits into
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3976 +/- ##
=============================================
- Coverage 55.47% 55.47% -0.00%
+ Complexity 19537 19536 -1
=============================================
Files 3861 3861
Lines 178080 178082 +2
Branches 14818 14818
=============================================
- Hits 98771 98767 -4
- Misses 75424 75431 +7
+ Partials 3885 3884 -1 🚀 New features to boost your workflow:
|
…e-popover-typescript-strict
| this.myDpOptions.disableUntil = { | ||
| day: Utils.subtractSafely(getDate(this.edge?.firstSetupProtocol), 1) ?? 1, | ||
| month: Utils.addSafely(getMonth(this.edge?.firstSetupProtocol), 1) ?? 1, | ||
| day: Utils.subtractSafely(getDate(dateInput), 1) ?? 1, |
There was a problem hiding this comment.
Utils is deprecated. Replace with NumberUtils
| month: Utils.addSafely(getMonth(this.edge?.firstSetupProtocol), 1) ?? 1, | ||
| day: Utils.subtractSafely(getDate(dateInput), 1) ?? 1, | ||
| month: Utils.addSafely(getMonth(dateInput), 1) ?? 1, | ||
| year: this.edge?.firstSetupProtocol?.getFullYear() ?? 2013, |
There was a problem hiding this comment.
That entire logic was flawed. Please see my changes.
Review of session changes
No remaining concerns — this is a solid, self-contained improvement on top of the already-reviewed diff, and it's fully covered by the existing |
Changes