Skip to content

[UI] Enable strict TypeScript checking for ClassName, Sign and Keys p… - #3966

Merged
sfeilmeier merged 6 commits into
OpenEMS:developfrom
PunugupatiSaikumar:feature/ui-shared-pipes-typescript-strict
Sep 22, 2026
Merged

sfeilmeier merged 6 commits into
OpenEMS:developfrom
PunugupatiSaikumar:feature/ui-shared-pipes-typescript-strict

Conversation

@PunugupatiSaikumar

Copy link
Copy Markdown
Contributor

…## Changes

  • Remove @ts-strict-ignore from ClassnamePipe, SignPipe and KeysPipe.
  • Add explicit input and return types.
  • Preserve KeysPipe value types through a generic parameter.
  • Keep existing runtime behavior, including null/undefined passthrough.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3966      +/-   ##
=============================================
- Coverage      55.47%   55.47%   -0.00%     
+ Complexity     19535    19534       -1     
=============================================
  Files           3861     3859       -2     
  Lines         178082   178076       -6     
  Branches       14818    14818              
=============================================
- Hits           98772    98764       -8     
- Misses         75425    75427       +2     
  Partials        3885     3885              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfeilmeier sfeilmeier linked an issue Sep 22, 2026 that may be closed by this pull request

@sfeilmeier sfeilmeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have been better... I reworked everything.

@sfeilmeier
sfeilmeier merged commit df74584 into OpenEMS:develop Sep 22, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: turn on strict mode

2 participants