feat: enumerate ADC resistor-ladder buttons as event entities - #87
Open
teancom wants to merge 1 commit into
Open
feat: enumerate ADC resistor-ladder buttons as event entities#87teancom wants to merge 1 commit into
teancom wants to merge 1 commit into
Conversation
Ladder blocks (input_type=3) share one ADC pin, so the input_flags pin bitmask is empty and the button count/id base live in the reserved tail. Enumerate them alongside digital buttons, and translate the tracker's button_slot_changed / press_count_changed transitions into down/up events so ladder buttons sharing a report byte fire reliably even when BLE advertisement frames are lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the release of py-opendisplay 7.14.1, analog buttons now work end-to-end. Tested on my local HA server with an XTEINK X4 using the buttons to page through "panels" of a dashboard. I'm not gonna say it's the fastest thing in the world but it works. 😅
Ladder blocks (input_type=3) share one ADC pin, so the input_flags pin bitmask is empty and the button count/id base live in the reserved tail. Enumerate them alongside digital buttons, and translate the tracker's button_slot_changed / press_count_changed transitions into down/up events so ladder buttons sharing a report byte fire reliably even when BLE advertisement frames are lost.