chore: remove obsolete sync-tag-definitions workflow - #82
Merged
Conversation
The workflow regenerated FALLBACK_TAG_DEFINITIONS in const.py from the OpenEPaperLink tag type definitions, using scripts/fetch_tag_types.py and scripts/generate_tag_types.py. The 3.0 rewrite removed all three: both scripts and the FALLBACK_TAG_DEFINITIONS table they edit are gone from this branch. The workflow still succeeds on main only because main is still the old architecture; on this branch it fails at its first step, and it would start failing on main the moment this branch lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow regenerated
FALLBACK_TAG_DEFINITIONSinconst.pyfrom the OpenEPaperLink tag type definitions, viascripts/fetch_tag_types.pyandscripts/generate_tag_types.py.The 3.0 rewrite removed all three. Both scripts and the
FALLBACK_TAG_DEFINITIONStable they edit are gone from this branch.It still succeeds on
main(weekly, most recently today) only becausemainis still the old architecture. On this branch it fails at its first step, and it would begin failing onmainas soon as this branch lands, so removing it here is the right place.No other file references the workflow or either script.