Remove SAML request from URL in wayf#1987
Open
johanib wants to merge 3 commits into
Open
Conversation
johanib
force-pushed
the
feature/1973-hide-url-in-bar
branch
from
51638a6 to
bb9e0d0
Compare
Contributor
Author
|
Blocked by: #1973 (comment) |
kayjoosten
force-pushed
the
feature/1973-hide-url-in-bar
branch
from
8821434 to
dba96a5
Compare
Prior to this change, users would bookmark the wayf. This caused expired/old saml requests from being handled by EB. EB does not have issues with that, but the SP might. This change prevents users from bookmarking SAML requests. Resolves #1703
Prior to this change, when the user would click the wrong IdP in the wayf, then used the back button, an error page would be shown, because the saml request was gone from the url. This change stores the saml request in the session when visiting the wayf. This way, when the wayf is visited without a request, the last used request will be used. Fixes #1973
Session-based back-button recovery removed — replaying the stored SAMLRequest fails with "No authentication request received" because Corto state is already consumed. pmeulen's decision: show the error, don't try to fix it. Flag eb.hide_bookmarkable_url (off by default) controls only the JS url-replace behaviour via the wayfConfig JSON payload. Closes #1973
kayjoosten
force-pushed
the
feature/1973-hide-url-in-bar
branch
from
dba96a5 to
ed980dc
Compare
3 tasks
kayjoosten
force-pushed
the
feature/1973-hide-url-in-bar
branch
from
a66b618 to
ed980dc
Compare
johanib
commented
Jun 18, 2026
| $this->expectException(MissingParameterException::class); | ||
|
|
||
| $requestValidator = Mockery::mock(RequestValidator::class); | ||
| $requestValidator->shouldReceive('isValid')->andThrow(new MissingParameterException('The parameter "SAMLRequest" is missing')); |
Contributor
Author
There was a problem hiding this comment.
The only thing this tests: is 'isValid' called??? 🤔
Probably good to remove this test
johanib
commented
Jun 18, 2026
johanib
left a comment
johanib
left a comment
Contributor
Author
There was a problem hiding this comment.
Went through it: LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, users would bookmark the wayf. This caused expired/old saml requests from being handled by EB. EB does not have issues with that, but the SP might.
This change prevents users from bookmarking SAML requests.
Resolves #1973