Add: behat test to test idempotentcy#94
Open
kayjoosten wants to merge 9 commits into
Open
Conversation
…eatureContext Remove PHP 7.4+ typed property syntax and PHP 7.3+ trailing commas in function calls — the Behat container uses an older PHP version.
Contributor
Author
|
@johanib this ci still fails that is what we want. After merging OpenConext/Stepup-Middleware#595 and OpenConext/Stepup-Middleware#587 they should succeed. |
Aligns with the php85-apache2-node24 base image already used by EngineBlock. Restores typed property and trailing commas now that PHP 8.5 is in use.
mariadb-client 11.4+ in the php85 base image requires TLS by default; the dev mariadb server does not offer it, so every mysql/mysqldump call failed with ERROR 2026.
- replace abandoned mink-goutte-driver/mink-extension with mink-browserkit-driver + friends-of-behat/mink-extension (browserkit_http sessions in behat.yml) - guzzle now an explicit dependency (was transitive via Goutte) - phpunit 5.7 -> 12: assert functions are namespaced, so contexts use Assert:: static calls; string assertContains variants renamed - ramsey/uuid 3 -> 4; drop moontoast/math and random_compat - symfony/mime required by BrowserKit for non-empty request bodies
An empty service_providers list is rejected by middleware
("at least one service_provider must be configured"). Push the
full fixtures/middleware-config.json twice instead, via a new
'I have the payload from file' step.
Temporarily tag with @Skip so the PHP 8.5 suite upgrade can be validated in CI without this feature failing the run. Remove the tag once CI is green.
The published openconext-devconf:test image is only rebuilt via manual
workflow_dispatch and still contains PHP 7.2, which cannot parse the
PHP 8.5 vendor code ("syntax error, unexpected '='"). Build the image
from stepup/tests/Dockerfile in the test run itself so the suite always
matches the branch. Drop --ignore-platform-reqs: it only masked the
PHP version mismatch.
PHP 8.5 suite upgrade verified green in CI; remove the temporary @Skip tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.