Repository navigation
fix(repo): rewrite services exported to the systemd user directory - #2172
Open
iloveeyjafjalla wants to merge 1 commit into
Open
iloveeyjafjalla wants to merge 1 commit into
iloveeyjafjalla wants to merge 1 commit into
Conversation
Collaborator
|
Hi @iloveeyjafjalla. Thanks for your PR. I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2171
The normal export destination is
entries/lib/systemd/user, but both the export rewrite check andIniLikeFileRewriteonly recognizedshare/systemd/user. Accept the standardlibpath at both points so the existing systemd command rewriter actually runs for current services and legacy services mapped to that destination.The regression starts with the real configured
app-conf-generator: it confirmsExecStartis already wrapped whileExecStartPostis still raw, imports the resulting service through real OSTree, and calls the productionexportDirvia the existing test access wrapper with no mock callbacks. It checks both source layouts, the exported symlink content, correct single wrapping, unchanged non-command metadata and re-export behavior. Original production code failed the post-start command assertion in all four layout/export combinations.Validation on Ubuntu 22.04 WSL2 x86_64 / GCC 11.4 / Qt 5.15.3 / CMake 3.31.6:
The full test environment uses isolated upstream erofs-utils 1.8 in a private Linux mount namespace and runs CTest as an ordinary user; the system installation remains 1.4. This verifies the helper/import/production export-function path, not full
exportAppReference, systemd service activation or container execution. Release, Qt6/ARM CI and live remote service requests were not run. Existing command-field selection and parsing semantics are unchanged.AI assistance: prepared and independently reviewed with OpenAI Codex. Executed failure and passing results are backed by retained Linux logs.