Repository navigation
fix(utils): clean read-only temporary package directories - #2170
Open
iloveeyjafjalla wants to merge 1 commit into
Open
iloveeyjafjalla wants to merge 1 commit into
iloveeyjafjalla wants to merge 1 commit into
Conversation
Collaborator
|
Hi @iloveeyjafjalla. Thanks for your PR. I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2169
When a real OSTree temporary merged checkout contains a read-only package directory,
remove_allcan fail andTemporaryDirectorysilently discards its cleanup path. Retry after using the existing directory-only permission helper; log any cleanup error that remains.The regression imports binary/develop modules into a real temporary OSTree repository, preserving a read-only directory before checkout. It confirms the temporary tree is removed after
TempLayerDirdestruction and the installed package file keeps its permissions. Original production code fails with the temporary path still present. Root skips this permission test explicitly; validation ran as the ordinary Linux user.Validation on Ubuntu 22.04 WSL2 x86_64 / GCC 11.4 / Qt 5.15.3 / CMake 3.31.6:
The complete test environment uses upstream erofs-utils 1.8 in a private Linux mount namespace, then runs CTest as an ordinary user; the system's 1.4 installation stays unchanged. Release, Qt6/ARM CI, complete UABX export, container launch and live remote service requests were not tested. Explicit external symlink/hardlink fixtures and arbitrary root-permission failures were not tested; the reused helper's directory-only behavior was reviewed from source. Hosted checks will be reported separately after publication.
AI assistance: prepared and independently reviewed with OpenAI Codex. The executed results and failure/pass logs are retained.