Repository navigation
Conversation
Collaborator
|
Hi @Metastarx. Thanks for your PR. I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…anager calls The install, update and uninstall policies are auth_admin_keep, but the grant obtained by one ll-package-manager process was never visible to the next one started by a fresh ll-cli invocation, so every command asked for the password again. Keep the authorization in a cache keyed by the user and the login session, and consult it before asking polkit again. The credentials the cache is keyed on are read back from the bus daemon, which is the only party that knows which connection made the call. OpenAtom-Linyaps#1904 Signed-off-by: zhang hongyuan <100520587+Metastarx@users.noreply.github.com>
Metastarx
force-pushed
the
patch/ll-package-manager-auth-admin-keep
branch
from
October 12, 2026 08:52
009d61c to
078cbad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each
ll-cli install,ll-cli updateorll-cli uninstallstarts a brand new process, and the daemon authorized it with a polkitsystem-bus-namesubject, which polkit resolves to that very process. The install/update/uninstall policies useauth_admin_keep, but the retained authorization is keyed on the subject, so the freshly started process never matched it and the authentication dialog appeared for every single command. The daemon now asks the bus daemon for the caller's uid and resolves its login session, remembers a successful check for that user and session for the same five minutes polkit would have kept it, and skips the polkit round trip inside that window.#1904
Changes
Verification
ctest --test-dir build-release --output-on-failure— passed (100% tests passed, 0 tests failed out of 744)Checklist