Repository navigation
Conversation
|
Hi @chennaji9. Thanks for your PR. I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
cleanBuildArtifacts() treated a failing exists() query (error_code set, e.g. EACCES on a parent) as "directory absent" and returned success, silently skipping the cleanup; check the error_code first and return an error, keeping the legitimate not-exist case as success. Signed-off-by: 陈那几 <2078634206@qq.com>
dc8acd7 to
880b344
Compare
What does this PR do?
Builder::cleanBuildArtifacts()treated a failing stat query as "nothing to clean":exists()also returns false when the query itself fails (error_code set — e.g. a parent directory lost search permission). The error is swallowed and the cleanup silently reports success without removing anything.Check the query outcome first and propagate the error; the legitimate "directory absent" case still returns success.
Validation
remove_allcall later in the same function (filesystem error_code checked and wrapped with the path).ll-testsbuilds cleanly with the change (the Builder class has no unit-test seam for constructinginternalDirstates, so this is validated by build + code path review).🤖 Generated with Claude Code