Repository navigation
Conversation
|
Hi @chennaji9. Thanks for your PR. I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
parse_args() always appended the terminating nullptr, so running ll-init without arguments produced {nullptr} instead of an empty vector; the "no arguments provided" branches in both callers were unreachable and execution fell through to execvp with a null file name; return an empty vector when no arguments exist.
Signed-off-by: 陈那几 <2078634206@qq.com>
1d69e31 to
13988d2
Compare
|
@reddevillg 您好,打扰一下~CI 这边仍在等 org 成员的 /ok-to-test 放行(commitlint 问题 10-15 已修复跟进)。方便的话能否帮忙触发一下 CI?绿了之后也恳请帮忙 review、合入,辛苦了,感谢! |
What does this PR do?
parse_args()in ll-init appended the terminatingnullptrunconditionally:so running
ll-initwith no arguments produced{nullptr}, never an empty vector. Theif (args.empty())guards in both callers —delegate_run()("no arguments provided for delegate run") andrun_init()("no arguments provided") — were unreachable, and execution continued to::execvp(args[0], ...)with a null file name (undefined behavior).Return the empty vector when no arguments exist so the existing guards work; the terminating
nullptris only appended for non-empty argument lists.Validation
delegate_runandrun_initonly touchargs[0]/args.data()after the (now reachable) empty check, so the empty vector is safe.ll-initbuilds cleanly with the change (cmake --build --preset debug --target linglong__ll-init).