Skip to content

fix(ll-driver-detect): detect config write failures in saveConfig #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chennaji9 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(ll-driver-detect): detect config write failures in saveConfig #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67c6167
fix(ll-driver-detect): detect config write failures in saveConfig
chennaji9 Sep 30, 2026
7e34b3e
chore: align copyright headers with the SPDX year checker
chennaji9 Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/ll-driver-detect/src/driver_detection_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: LGPL-3.0-or-later

Expand Down Expand Up @@ -64,6 +64,11 @@
file << jsonConfig.dump(4); // Pretty print with 4 spaces
file.close();

if (!file.good()) {
LogW("failed to write driver detection config to {}", configFilePath);
return false;
}

Check warning on line 70 in apps/ll-driver-detect/src/driver_detection_config.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

The function 'recordUserChoice' is never used.

return true;
}

Expand Down
13 changes: 12 additions & 1 deletion libs/linglong/tests/ll-tests/src/apps/ll-driver-detect/driver_detection_config_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
* SPDX-FileCopyrightText: 2026 UnionTech Software Technology Co., Ltd.
*
* SPDX-License-Identifier: LGPL-3.0-or-later
*/
Expand Down Expand Up @@ -69,3 +69,14 @@ TEST_F(DriverDetectionConfigTest, SaveAndLoadConfig)
auto loadedConfig = manager2.getConfig();
EXPECT_TRUE(loadedConfig.neverRemind);
}

TEST_F(DriverDetectionConfigTest, SaveConfigFailsOnWriteError)
{
using namespace linglong::driver::detect;

// Opening /dev/full succeeds but every write fails with ENOSPC; if the
// device is unavailable the open itself fails, so the save must report
// failure either way instead of silently losing the user's choice
DriverDetectionConfigManager manager("/dev/full");
EXPECT_FALSE(manager.saveConfig());
}
Loading