Repository navigation
Conversation
|
Hi @chennaji9. Thanks for your PR. I'm waiting for a OpenAtom-Linyaps member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
In install-only mode, the tool logged a warning when installDriverPackage failed but still printed the success message and returned exit code 0, so scripts and callers could not detect the failure. Return 1 on failure and only report success on success, matching the interactive path. Signed-off-by: 陈那几 <2078634206@qq.com>
The SPDX Year Range Checker in the license-check workflow requires the copyright header of a file modified in 2026 to cover 2026. Extend the range on the one file this PR touches; no code change. Signed-off-by: 陈那几 <2078634206@qq.com>
c06031d to
da5af31
Compare
2 participants
What does this PR do?
In
ll-driver-detect --install-onlymode, aninstallDriverPackage()failure was only logged as a warning — the tool then printedSuccessfully installed driver packageand still exited with status 0, so scripts and callers could not detect the failure.Return
1on failure and only print the success message (and return0) when the installation actually succeeded, matching the interactive installation path in the same file, which already returns1on failure.Validation
cmake --build --preset debug).--install-onlybranch now mirrors the exit-status handling of the interactive branch (apps/ll-driver-detect/src/main.cpp, interactive path returns 1 wheninstallDriverPackagefails).