Repository navigation
Conversation
The shared repo command implementation (libs/linglong/src/linglong/common/cli/repo.cpp, used by both ll-cli and ll-builder) registers a --region option on enable-mirror, and ll-cli-repo(1) already documents it, but ll-builder-repo(1) omitted it in both Chinese and English pages. Add the --region option and a --region CN example to both pages. Signed-off-by: muzimu217 <1278844978@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
ll-builder repo enable-mirror的手册页(中英文)只记录了alias位置参数,缺少--region选项的说明。而 ll-cli 与 ll-builder 共用同一份 repo 子命令实现(libs/linglong/src/linglong/common/cli/repo.cpp,通过apps/ll-builder/src/command_options.h引入linglong/common/cli/repo.h),代码中enable-mirror已注册--region REGION选项(repo.cpp:118-122),且ll-cli-repo(1)的中英文文档均已记载该选项(docs/pages/guide/reference/commands/ll-cli/repo.md:122),导致 ll-builder 文档与实际 CLI 能力不一致。修改
docs/pages/guide/reference/commands/ll-builder/repo.md:enable-mirror子命令补充--region REGION选项说明,并新增ll-builder repo enable-mirror myalias --region CN示例docs/pages/en/guide/reference/commands/ll-builder/repo.md:同步英文页面验证证据
libs/linglong/src/linglong/common/cli/repo.cpp:118处repoEnableMirror->add_option("--region", ...);apps/ll-builder/src/command_options.h包含linglong/common/cli/repo.h,证明 ll-builder 复用该共享实现docs/pages/{,en/}guide/reference/commands/ll-builder/repo.md中enable-mirror条目无--region,而ll-cli/repo.md已有对应记载ll-builder/repo.md;open issue 中亦无相关报告Signed-off-by: muzimu217 1278844978@qq.com