Skip to content

feat: Phase R R4 scientific review readiness gate (SRG-) -- machine-verifiable checklist for external review - #962

Merged
cschanhniem merged 1 commit into
mainfrom
feat/r4-scientific-review-readiness-gate
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/r4-scientific-review-readiness-gate

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Implements R4 from NEXT_100_PR_MAP.

What

  • src/openamp_foundry/evidence/scientific_review_readiness_gate.py: SRG- schema; ScientificReviewReadinessGate dataclass (15 fields); validate_scientific_review_readiness_gate(); build_scientific_review_readiness_gate() (enforces dry_lab_only=True); format_scientific_review_readiness_gate()
  • REQUIRED_SRG_ARTIFACT_TYPES (4): CFC, FNR, ATR, PQG
  • VALID_READINESS_VERDICTS (4): ready_for_external_review, not_ready, conditionally_ready, review_blocked_by_safety
  • VALID_SAFETY_FLAG_TYPES (6): unresolved_hemolysis, unresolved_toxicity, dual_use_concern, off_target_risk, contamination_suspected, no_flags
  • VALID_REVIEW_SCOPE_TYPES (4): internal_only, trusted_partner, open_preprint, peer_review_submission
  • tests/evidence/test_scientific_review_readiness_gate.py: 63 tests in 5 classes
  • BASELINE: 9089 → 9152

Disconfirming pass

  • dry_lab_only=False blocked (tested)
  • TOY- family ID blocked (tested)
  • review_blocked_by_safety requires real flag (not 'no_flags') (tested)
  • ready_for_external_review blocks safety flags (tested)
  • ready_for_external_review blocks failed_gates (tested)
  • ready_for_external_review requires n_confirmed_hits >= 1 (tested)
  • no_flags cannot coexist with other flags (tested)
  • open_preprint/peer_review blocked when not_ready or review_blocked_by_safety (tested)

…erifiable review checklist; REQUIRED_SRG_ARTIFACT_TYPES (CFC/FNR/ATR/PQG), VALID_READINESS_VERDICTS (4), VALID_SAFETY_FLAG_TYPES (6); open_preprint blocked when not_ready/safety_blocked; dry_lab_only=True enforced; 63 tests (#960)
@cschanhniem
cschanhniem merged commit 7b983b5 into main Jul 10, 2026
1 check failed
cschanhniem added a commit that referenced this pull request Jul 10, 2026
Co-authored-by: OpenCode <opencode@example.com>
cschanhniem added a commit that referenced this pull request Jul 10, 2026
…e snapshot for preprint submission; VALID_BUNDLE_STATUSES (5), VALID_PREPRINT_SERVERS (7), VALID_CLAIM_STRENGTH_TIERS (4); DRY_LAB_ONLY_DISCLAIMER enforced; published requires DOI; replicated_wet_lab requires 2+ hits; closes Phase R (#962) (#964)

Co-authored-by: OpenCode <opencode@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant