Skip to content

feat: Phase R R2 family novelty report (FNR-) -- prevents novel family overclaim via cheap-baseline comparison - #958

Merged
cschanhniem merged 1 commit into
mainfrom
feat/r2-family-novelty-report
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/r2-family-novelty-report

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Implements R2 from NEXT_100_PR_MAP.

What

  • src/openamp_foundry/evidence/family_novelty_report.py: FNR- schema; FamilyNoveltyReport dataclass (13 fields); validate_family_novelty_report(); build_family_novelty_report() (enforces dry_lab_only=True); format_family_novelty_report()
  • VALID_BASELINE_COMPARISON_OUTCOMES (4): outside_known_space, within_known_space, edge_of_known_space, comparison_not_run
  • VALID_NOVELTY_STRENGTH_GRADES (4): strong, moderate, weak, not_supported
  • VALID_CHEAP_BASELINES_CHECKED (5): charge_distribution, length_distribution, hydrophobicity_profile, isoelectric_point, aromaticity
  • tests/evidence/test_family_novelty_report.py: 63 tests in 5 classes
  • BASELINE: 8963 → 9026

Disconfirming pass

  • dry_lab_only=False blocked (tested) — novelty report is computational
  • strong grade requires outside_known_space outcome (tested)
  • not_supported incompatible with outside_known_space (tested)
  • strong grade blocked with comparison_not_run (tested)
  • cheap_enemy_score/family_score must be in [0,1] (tested)
  • empty cheap_baselines_checked blocked (tested)
  • invalid baseline/grade/outcome values blocked (tested)

…eap-baseline comparison; VALID_BASELINE_COMPARISON_OUTCOMES (4), VALID_NOVELTY_STRENGTH_GRADES (4), VALID_CHEAP_BASELINES_CHECKED (5); strong grade requires outside_known_space; not_supported incompatible with outside_known_space; 63 tests (#956)
@cschanhniem
cschanhniem merged commit 8259ce1 into main Jul 10, 2026
1 check failed
cschanhniem added a commit that referenced this pull request Jul 10, 2026
Co-authored-by: OpenCode <opencode@example.com>
cschanhniem added a commit that referenced this pull request Jul 10, 2026
…CR->PQG; VALID_TRAIL_COMPLETENESS_STATUSES (4), VALID_CHAIN_INTEGRITY_GRADES (5); complete status enforces all 5 stages; grade D incompatible with complete; dry_lab_only=True enforced; 63 tests (#958) (#960)

Co-authored-by: OpenCode <opencode@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant