Skip to content

feat: Phase R R1 candidate family clustering schema (CFC-) -- machine-verifiable novel family claim - #956

Merged
cschanhniem merged 1 commit into
mainfrom
feat/r1-candidate-family-clustering
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/r1-candidate-family-clustering

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Implements R1 from NEXT_100_PR_MAP — starts Phase R (scientific output readiness).

What

  • src/openamp_foundry/evidence/candidate_family_clustering.py: CFC- schema; CandidateFamilyClustering dataclass (15 fields); validate_candidate_family_clustering(); build_candidate_family_clustering() (enforces dry_lab_only=True); format_candidate_family_clustering()
  • VALID_NOVELTY_EVIDENCE_TYPES (6): blast_search_no_hits, hmm_profile_no_match, structural_divergence, charge_length_outside_known, expert_assessment, insufficient_evidence
  • VALID_CLUSTERING_METHODS (5): sequence_identity, edit_distance, kmer_similarity, embedding_distance, manual_grouping
  • VALID_NOVELTY_VERDICTS (4): novel_family, variant_of_known, insufficient_evidence, disputed
  • tests/evidence/test_candidate_family_clustering.py: 63 tests in 5 classes
  • BASELINE: 8900 → 8963

Disconfirming pass

  • dry_lab_only=False blocked (tested) — clustering is computational
  • TOY- candidate IDs blocked (tested)
  • novel_family requires hard evidence (blast/hmm/structural/charge) — expert_assessment alone insufficient (tested)
  • variant_of_known requires known_family_hits (tested)
  • n_candidates < 2 blocked (tested) — single-candidate families not allowed
  • n_candidates mismatch with candidate_ids length blocked (tested)
  • min_pairwise_similarity > max_pairwise_similarity blocked (tested)

…OVELTY_EVIDENCE_TYPES (6), VALID_CLUSTERING_METHODS (5), VALID_NOVELTY_VERDICTS (4); novel_family requires hard evidence; variant_of_known requires known_family_hits; dry_lab_only=True enforced; 63 tests (#954)
@cschanhniem
cschanhniem merged commit 8c2b47b into main Jul 10, 2026
1 check failed
cschanhniem added a commit that referenced this pull request Jul 10, 2026
Co-authored-by: OpenCode <opencode@example.com>
cschanhniem added a commit that referenced this pull request Jul 10, 2026
…eap-baseline comparison; VALID_BASELINE_COMPARISON_OUTCOMES (4), VALID_NOVELTY_STRENGTH_GRADES (4), VALID_CHEAP_BASELINES_CHECKED (5); strong grade requires outside_known_space; not_supported incompatible with outside_known_space; 63 tests (#956) (#958)

Co-authored-by: OpenCode <opencode@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant