Skip to content

feat: Phase Q Q5 completeness gate (PQG-) -- machine-verifiable full dry-lab→wet-lab→calibration loop check - #954

Merged
cschanhniem merged 1 commit into
mainfrom
feat/q5-phase-q-completeness-gate
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/q5-phase-q-completeness-gate

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Implements Q5 from NEXT_100_PR_MAP — closes Phase Q.

What

  • src/openamp_foundry/evidence/phase_q_completeness_gate.py: PQG- schema; PhaseQCompletenessGate dataclass (12 fields); validate_phase_q_completeness_gate(); build_phase_q_completeness_gate() (enforces dry_lab_only=False); format_phase_q_completeness_gate()
  • REQUIRED_RECORD_TYPES (4): BSP, WHR, PCU, HCR
  • VALID_LOOP_VERDICTS (4): loop_complete, loop_partial, loop_not_started, loop_broken
  • tests/evidence/test_phase_q_completeness_gate.py: 63 tests in 5 classes
  • BASELINE: 8837 → 8900

Disconfirming pass

  • dry_lab_only=True blocked (tested) — real wet-lab loop required
  • TOY- candidate_family_id blocked (tested)
  • loop_complete requires all 4 record types (tested each individually)
  • loop_complete blocks cross_link_failures (tested)
  • loop_complete blocks missing_record_types (tested)
  • loop_not_started blocks any WHR/PCU/HCR records (tested each)
  • n_candidates_with_hcr > n_candidates_with_whr blocked (tested)
  • invalid ID prefixes blocked for all record types (BSP/WHR/PCU/HCR tested)

…loop check; REQUIRED_RECORD_TYPES (BSP/WHR/PCU/HCR), VALID_LOOP_VERDICTS (4); loop_complete enforces all four record types present and cross-links clean; closes Phase Q (#952)
@cschanhniem
cschanhniem merged commit 28f4bc6 into main Jul 10, 2026
1 check failed
cschanhniem added a commit that referenced this pull request Jul 10, 2026
…NEXT_100_PR_MAP (#954) (#955)

Co-authored-by: OpenCode <opencode@example.com>
cschanhniem added a commit that referenced this pull request Jul 10, 2026
…OVELTY_EVIDENCE_TYPES (6), VALID_CLUSTERING_METHODS (5), VALID_NOVELTY_VERDICTS (4); novel_family requires hard evidence; variant_of_known requires known_family_hits; dry_lab_only=True enforced; 63 tests (#954) (#956)

Co-authored-by: OpenCode <opencode@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant