Skip to content

feat: Phase E E7 packet validator CLI -- review readiness is now testable - #946

Merged
cschanhniem merged 1 commit into
mainfrom
feat/e7-packet-validator-cli
Jul 10, 2026
Merged

cschanhniem merged 1 commit into
mainfrom
feat/e7-packet-validator-cli

Conversation

@cschanhniem

Copy link
Copy Markdown
Collaborator

Implements E7 from NEXT_100_PR_MAP.

What

  • src/openamp_foundry/cli/commands/validate_packet.py: load_packet_from_json() reads ERP- JSON from disk; validate_packet_file() returns {valid, violations, packet_id, error}; _run_validate_packet() prints PASS/FAIL with violations; all parse helpers (_parse_candidate_entries, _parse_benchmark_summaries, etc.)
  • tests/cli/test_validate_packet.py: 45 tests in 7 classes
  • BASELINE: 8585 → 8648

Disconfirming pass

  • No safety gates modified — this is a READ-ONLY validator
  • dry_lab_only_attestation=False correctly produces FAIL (tested)
  • empty limitations correctly produces FAIL (tested)
  • Missing file returns exit code 1, not a crash
  • Valid packet from examples/ structure passes

… ERP- JSON from disk, validates via validate_external_review_packet(), _run_validate_packet() PASS/FAIL CLI; 45 tests (#945)
@cschanhniem
cschanhniem merged commit 98c967b into main Jul 10, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant