Repository navigation
feat: document phase3.yaml AUROC and add synthesis-gate regression test - #63
Merged
Merged
Conversation
- METHODS.md § 8: add phase3.yaml retrospective benchmark results (AUROC=0.7936, 95% CI 0.6963-0.8827; AUPRC=0.8333; all STRONG ≥0.70) and note that phase3 is the operationally relevant synthesis gate - Add make validate-scoring-phase3 target for phase3-specific benchmark - Add test_phase3_benchmark_passes_gate: asserts AUROC ≥ 0.75 using phase3.yaml weights (guards against regression in synthesis gate) - 1185 tests passing
- Remove dead assert (>0.70 was shadowed by >=0.75 regression sentinel); keep gate check >0.70 as primary, sentinel >=0.75 with accurate message - Add upper-bound sentinel <0.83 so test fails if pipeline.yaml is silently loaded instead of phase3.yaml (pipeline AUROC=0.8164 would breach it) - METHODS.md: note that CI spanning gate boundary is expected at n=88 and synthesis decisions use point estimates (standard practice)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make validate-scoring-phase3target to compute AUROC/AUPRC using phase3.yaml weights, making it reproducible from a single command.Why this matters
The code reviewer flagged (CRITICAL) in PR #60 that the documented AUROC of 0.8164 was for pipeline.yaml but the synthesis selection gate uses phase3.yaml with different weights and a stricter safety gate. This PR fixes that documentation gap and pins it with a regression test.
Test plan
make validate-scoring-phase3runs and produces AUROC=0.7936, AUPRC=0.8333make validate-scoringstill produces AUROC=0.8164 (pipeline.yaml unaffected)test_phase3_benchmark_passes_gatePASSES (1185 tests green)🤖 Generated with Claude Code