Repository navigation
docs: respond to external expert review — calibrate discovery probability - #57
Merged
Merged
Conversation
…templates - DISCOVERY_PREDICTION.md: add External Calibration section with honest re-estimate (15–30% accounting for near-seed correlation vs internal 29–49%), competitive landscape (AMPGAN v3, ESCAPE benchmark), benchmark limitations, and concrete path-to-uplift table - ROADMAP.md: fix stale 29-49% reference, add expert review template note, add 'Beyond v1.0' gap table covering large-scale benchmark, external predictor adapters, true novelty check, and publication track - .github/ISSUE_TEMPLATE/expert_review.yml: structured GitHub issue template for domain-expert / wet-lab collaborator sign-off before synthesis
- Replace incorrect '8 scaffolds × 40-60% per-scaffold rate' claim (that math gives >99%, not 15-30%) - Add explicit derivation: per-scaffold all-gates rate 1.6-3.1% from original model × 8 effective independent scaffolds → P(≥1) ≈ 12-22%, rounded to 15-30% accounting for model uncertainty - Add forward-reference to External Calibration in executive summary - Flag AMPGAN v3 arXiv ID as requiring confirmation before external citation Fixes HIGH issue from code-reviewer on PR #57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the external expert review (scored 24/100) that identified three critical gaps in the pre-wet-lab package:
Changes
docs/DISCOVERY_PREDICTION.mddocs/ROADMAP.md.github/ISSUE_TEMPLATE/expert_review.ymlTest plan
1172 passed in 0.90s— no regressions🤖 Generated with Claude Code