Repository navigation
test: pin empty selection_reason passthrough in build_certificate - #30
Merged
Merged
Conversation
The _make_scored() helper in test_certificate.py uses 'or' short-circuit (selection_reason or ['default']), so passing selection_reason=[] silently becomes the default value — no test has ever exercised the empty-list path. Added test_empty_selection_reason_passthrough that bypasses the helper and directly constructs ScoredCandidate(selection_reason=[]) to verify: 1. build_certificate() passes the empty list through unchanged 2. cert['selection_reason'] == [] (the JSON schema allows this — no minItems) This is the final audit-identified gap from the pre-synthesis quality sprint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final gap from audit: the
_make_scored()test helper intest_certificate.pyusesselection_reason or ["default"], which meansselection_reason=[]silently becomes the default value. No existing test has ever exercisedbuild_certificate()with an empty selection_reason list.Added
test_empty_selection_reason_passthroughthat bypasses the helper and directly constructsScoredCandidate(selection_reason=[]). Verifies:build_certificate()passes the empty list through unchangedcert["selection_reason"] == []minItemsconstraint onselection_reason)This is a low-risk gap (the code correctly handles it) but the untested blind spot in the helper was worth documenting explicitly.
Test plan
pytest tests/test_certificate.py— 23 passed (1 new test)