fix: add object.__init__() call in MFDatasetCommonDims and WebMapService classes#3078
fix: add object.__init__() call in MFDatasetCommonDims and WebMapService classes#3078shubhamdagar9854 wants to merge 2 commits into
Conversation
|
After investigation, the test failures are caused by two separate issues:
The following failures are pre-existing and unrelated to this PR:
|
The build Gallery and RTFD tests run without your change This is also a consequent of your changes FAILED tests/_test_mswms/test_mss_plot_driver.py::Test_HSec::test_invalid_crs_codes[EPSG:12345678] - OSError: master dataset /tmp/tmpjsajgeja/mswms/testdata/20121017_12_ecmwf_forecast.SFC.EUR_LL015.036.sfc.nc does not have a aggregation dimension |
|
I tried object.init(self) but it causes test failures as shown in CI. |
…ice classes
Purpose of PR?:
Fixes #2750
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Both classes were missing a call to the parent init. Added super().init() with appropriate arguments in both classes.
Does this PR results in some Documentation changes?
No
Checklist:
-[✅] Bug fix. Fixes #2750
-[✅] PR Title follows the convention of `fix : add object.init() call in MFDatasetCommonDims and WebMapService classes