Skip to content

Add PAL 1.0 fix of Wolfos slash state reset on hit - #2622

Open
djevangelia wants to merge 1 commit into
OoTRandomizer:Devfrom
djevangelia:wolfosattack
Open

Add PAL 1.0 fix of Wolfos slash state reset on hit#2622
djevangelia wants to merge 1 commit into
OoTRandomizer:Devfrom
djevangelia:wolfosattack

Conversation

@djevangelia

Copy link
Copy Markdown

It was noted in the OoT speedrunning Discord that Wolfos can have active hurtboxes after taking damage or getting stunned, ex https://www.youtube.com/watch?v=lU7l0mr1T30
This is due to Wolfos slashStatus not getting reset to 0 on damage/stun. This was fixed in PAL 1.0.
NTSC 1.0:

jal     Actor_SetDropFlag
move    a0,s0
lbu     v0,177(s0)
li      at,1
beq     v0,at,80b5fdd0 <EnWf_UpdateDamage+0x114>

NTSC 1.2:

jal     Actor_SetDropFlag
move    a0,s0
lbu     v0,177(s0)
li      at,1
sh      zero,744(s0)    ; <---- this->slashStatus = 0;
beq     v0,at,80b603b4 <EnWf_UpdateDamage+0x118>

This adds the fix. Maybe it's possible to hack it into the function itself, I didn't examine it closer than comparing the IDO assembly length with a GCC build (GCC is 2 instructions longer).

Testing

Tested in ares older nightly build and Project64 3.0.1. It doesn't crash, the function is being run and sets the slashStatus to zero. I didn't test the AT colliders themselves.
In bad quality video you can see breakpoint at sh zero,744(s0) and that it replaces one of the Wolfos' slashStatus.

wolfos.slash.fix.mp4

@shirosoluna

Copy link
Copy Markdown

This isnt a fix, stop calling version differences fixes. Its misleading

the original conversation in the oot discord is here with the twitch clips and count’s comments. https://discord.com/channels/82938430371139584/237772023374413835/1539520194269945876

I dont think this is significant enough to change

@fenhl fenhl added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Aug 26, 2026
@djevangelia

Copy link
Copy Markdown
Author

This isnt a fix, stop calling version differences fixes. Its misleading

the original conversation in the oot discord is here with the twitch clips and count’s comments. https://discord.com/channels/82938430371139584/237772023374413835/1539520194269945876

I dont think this is significant enough to change

Was there a different purpose to the version difference? Sorry, I don't see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants