Avoid placing precompleted rewards on Rauru - #2616
Open
fenhl wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
For the record and since the concern was brought up on Discord, the stats run showed that the numbers for the other rewards were fairly similar to each other, i.e. rewards were still properly shuffled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where, when “Pre-completed Dungeons Mode” is set to “Specific Rewards”, the randomizer could place one of the specified rewards on the
ToT Reward from Raurulocation, resulting in one fewer precompleted dungeon than expected.This fix is conceptually similar to an existing feature where in “Count” mode, non-MQ dungeons are prioritized to be selected as precompleted before MQ dungeons.
Testing
Tested using ootrstats with a settings string that has the Kokiri Emerald and Goron Ruby precompleted:
ootrstats --settings=BSAWDNCAX2TB2XCHGABSL62ANAEACASSSACAASBEASHASFAAJAJUJJASCACC6AJXAQL6KT2LAASAGADWBRAJCEH7KYCAF3WQYAAAJLNBA3CGZA2SRES8WBTPAZCAEGJNQ6A6B6DJAJTA3JGE categorize '.locations["ToT Reward from Rauru"]'reported that Rauru had the Kokiri Emerald in 1779 and the Goron Ruby in 1831 out of 16384 seeds, with 1 generator failure.ootrstats -ufenhl -bprecompleted-rauru --settings=BSAWDNCAX2TB2XCHGABSL62ANAEACASSSACAASBEASHASFAAJAJUJJASCACC6AJXAQL6KT2LAASAGADWBRAJCEH7KYCAF3WQYAAAJLNBA3CGZA2SRES8WBTPAZCAEGJNQ6A6B6DJAJTA3JGE categorize '.locations["ToT Reward from Rauru"]'reported no instances of Rauru holding either reward, with 0 generator failures.