Skip to content

Fix Japanese Instant Message GoTo Issue and some fixes for English Property - #2607

Open
JackTriton wants to merge 3 commits into
OoTRandomizer:Devfrom
JackTriton:LanguageFix-Speed
Open

Fix Japanese Instant Message GoTo Issue and some fixes for English Property#2607
JackTriton wants to merge 3 commits into
OoTRandomizer:Devfrom
JackTriton:LanguageFix-Speed

Conversation

@JackTriton

Copy link
Copy Markdown

This PR allows to fix the issue that OoT loads 0x8170 instead of what supposed to be loaded as TEXTID when the message started with instant but not ending with un-instant
This means now we can mash skip with not only English but also Japanese texts as well
Also this PR fixes the issue where English gets slower because of un-instant being auto placed due to Japanese message issue and forgot to ignore it when the Language is English based

This PR also fixes some English text issues which some textboxes have wrong indents
The messages are: granny_wrapped, medigoron_item, medigoron_wrapped and salesman_wrapped
I forgot to add additional line breaks and make them 4 lines instead of 3

@fenhl fenhl added Type: Bug Something isn't working Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Component: Patching Affects the patching of the ROM labels Jul 20, 2026
@flagrama

flagrama commented Jul 21, 2026

Copy link
Copy Markdown

Your newest commit is awful. Do not cast the variables, either fix the function definition, or fix what data you are sending.

@JackTriton

Copy link
Copy Markdown
Author

@flagrama I think it was pretty awful as well
I reverted the change and changed the definition's type instead
I think this would be much better compared to previous one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Component: Patching Affects the patching of the ROM Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants