Fix Japanese Instant Message GoTo Issue and some fixes for English Property - #2607
Open
JackTriton wants to merge 3 commits into
Open
Fix Japanese Instant Message GoTo Issue and some fixes for English Property#2607JackTriton wants to merge 3 commits into
JackTriton wants to merge 3 commits into
Conversation
|
Your newest commit is awful. Do not cast the variables, either fix the function definition, or fix what data you are sending. |
Author
|
@flagrama I think it was pretty awful as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to fix the issue that OoT loads
0x8170instead of what supposed to be loaded as TEXTID when the message started withinstantbut not ending withun-instantThis means now we can mash skip with not only English but also Japanese texts as well
Also this PR fixes the issue where English gets slower because of
un-instantbeing auto placed due to Japanese message issue and forgot to ignore it when the Language is English basedThis PR also fixes some English text issues which some textboxes have wrong indents
The messages are:
granny_wrapped,medigoron_item,medigoron_wrappedandsalesman_wrappedI forgot to add additional line breaks and make them 4 lines instead of 3