Repository navigation
fix: [SDK-5330] reject null, empty, and NUL identity strings - #210
Closed
abdulraqeeb33 wants to merge 1 commit into
Closed
abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
A blank or NUL external id was queued for the page SDK. Reject it before the deferred call, matching the other client SDKs. Co-authored-by: Cursor <cursoragent@cursor.com>
sherwinski
requested changes
Oct 7, 2026
sherwinski
left a comment
sherwinski
left a comment
Contributor
There was a problem hiding this comment.
@abdulraqeeb33 You will need to make these updates to https://github.com/OneSignal/web-shim-codegen before they get generated in the downstream wrappers
Author
|
Moved the guard into the generator: OneSignal/web-shim-codegen#144 Closing this. Vue, Vue 3, and Angular will be generated from that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject null, empty, and NUL identity strings before they are queued for the page SDK. Part of SDK-5327.
isMissinglogs and returns. Whitespace is still allowed. An empty tag value is allowed, including one that contains a null byte.setLanguage("")is still the reset. A null byte in the language code is rejected.The page SDK rejects the same values. This guard runs first so an older CDN script never receives them.
Test plan
vp test(5 tests passed), including empty and NUL login, a kept whitespace login, an empty tag value, a NUL tag key, andsetLanguage("")OneSignalDeferred.pushhttps://linear.app/onesignal/issue/SDK-5330
Made with Cursor