Fix battery self-discharge implementation - #165
Open
stuenergy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the battery self-discharge implementation in hour_simulation (for both "hybrids.py" and "hybrids_wind.py").
Previously, the self-discharge was added to battery_use, but the battery state of charge (soc) was not updated because the line
soc - 0.0002 * sochad no effect.
This changes the implementation to:
soc -= 0.0002 * socso that battery self-discharge is correctly applied to the state of charge.
This issue was discussed and confirmed by @AndreasSahlberg on the OnSSET discussion forum on May, 6th.