Repository navigation
Run tests in CI and before publishing - #16
Merged
Merged
Conversation
Add a test workflow that runs pytest on Python 3.11-3.13 for every PR and push to main, and make the publish workflow depend on it so a release can't go out with failing tests. Declare pytest and pytest-asyncio as a `test` extra so the suite can be installed with `pip install -e ".[test]"`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
There was no CI for tests. The only workflow,
publish.yml, built and uploaded to PyPI on a version bump without running the test suite. The test dependencies (pytest,pytest-asyncio) also weren't declared anywhere, so a plainpip install -e .followed bypytestdidn't work.Changes
.github/workflows/test.yml(new): runspyteston the latest stable Python (3.x) for every pull request and every push tomain. It also has aworkflow_calltrigger so other workflows can reuse it.publish.yml: adds atestjob that callstest.yml. Thepublishjob now hasneeds: test, so a failing test blocks the release.pyproject.toml: adds atestoptional-dependency extra listingpytest>=8.0andpytest-asyncio>=0.23.pip install -e ".[test]".Notes for reviewers
publish.yml, the tests now run on every push tomainthat changespyproject.toml, even when the version didn't change and nothing gets published. That costs a little CI time but avoids complicating the workflow.mainpass in a fresh virtualenv set up with onlypip install -e ".[test]". This PR's own checks should be the first real run of the workflow.🤖 Generated with Claude Code