Skip to content

Allow gtfs-realtime-bindings 3.x - #14

Merged
OnFreund merged 1 commit into
OnFreund:mainfrom
raman325:allow-gtfs-realtime-bindings-3
Oct 10, 2026
Merged

OnFreund merged 1 commit into
OnFreund:mainfrom
raman325:allow-gtfs-realtime-bindings-3

Conversation

@raman325

@raman325 raman325 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Relax gtfs-realtime-bindings==2.0.0 to gtfs-realtime-bindings>=2.0.0.

Why

py-nymta is the only package in Home Assistant core that pins gtfs-realtime-bindings, so its exact pin decides the version for every HA install. Bindings 3.0.0 (released 2026-09-17) adds proto fields such as FeedEntity.stop, trip_modifications, StopTimeProperties pickup/drop-off types and vehicle wheelchair_accessible. Other libraries need those fields, and right now they can't be used in core alongside the mta integration. I hit this with aiomobilitydatabase, the library behind the proposed mobilitydata integration (home-assistant/core#177905). Under HA's 2.0.0 its realtime parsing fails with Protocol message FeedEntity has no "stop" field.

A floor instead of ==3.0.0 keeps the original HA-compatibility intent of #8 and still allows 2.0.0. It also avoids the same lockstep problem the next time the bindings release.

Testing

py-nymta only parses FeedMessage, and 3.0.0 doesn't change any existing fields, only adds new ones. The test suite passes on both versions:

gtfs-realtime-bindings 2.0.0: 25 passed
gtfs-realtime-bindings 3.0.0: 25 passed

I left the version number alone so you can decide when to release. Once a release is out, I'm happy to open the core bump PR.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 7, 2026 03:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@OnFreund

Copy link
Copy Markdown
Owner

Thanks @raman325. Can you rebase to pick up CI tests?

Relax the exact ==2.0.0 pin to a >=2.0.0 floor. Bindings 3.0.0 only adds
proto fields, and the test suite passes on both 2.0.0 and 3.0.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@raman325
raman325 force-pushed the allow-gtfs-realtime-bindings-3 branch from 0c6d572 to dd7d1c3 Compare October 10, 2026 14:49
@OnFreund
OnFreund merged commit 88f4a2c into OnFreund:main Oct 10, 2026
1 check passed
@raman325
raman325 deleted the allow-gtfs-realtime-bindings-3 branch October 10, 2026 16:27
@OnFreund OnFreund mentioned this pull request Oct 12, 2026
@OnFreund

Copy link
Copy Markdown
Owner

0.4.3 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants