Repository navigation
Fetch the Franklin Av Shuttle from the BDFM feed - #13
Merged
Merged
Conversation
Owner
|
Thanks @restlessdesign. Can you rebase to pick up CI tests? |
The MTA publishes Franklin Avenue Shuttle (FS) trips in nyct/gtfs-bdfm, but LINE_TO_FEED mapped FS to the ACE feed, so get_arrivals() for any FS stop always returned an empty list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
restlessdesign
force-pushed
the
fix-franklin-shuttle-feed
branch
from
October 11, 2026 20:27
84601f9 to
0fcf38a
Compare
Contributor
Author
|
Rebased onto main, so it's now a single commit on top of the new CI. The test workflow may need your approval to run, since this PR comes from a fork. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MTA publishes Franklin Avenue Shuttle (
FS) trips innyct/gtfs-bdfm, butLINE_TO_FEEDmapsFSto"A"(nyct/gtfs-ace). As a result,get_arrivals()for any FS stop always returns an empty list. In Home Assistant's MTA integration, that makes the shuttle look like it isn't running.I counted
trip_updateentities per route in every subway feed on a weekday afternoon:gtfs-acegtfs-bdfmFSwas likewise absent from ACE and present in BDFM on two earlier checks. The Rockaway Park Shuttle (H) is correctly in ACE, so this change moves onlyFS.Changes
"FS"to feed"B"and update the two feed comments.FStotest_get_feed_id_for_route. It fails onmainand passes with this change; the full suite passes (25 tests).I left the version number alone, since your releases bump it.
🤖 Generated with Claude Code