Repository navigation
Release packaging: Linux AArch64 and native Termux AArch64 archives - #8
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4a9d515c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo 'Refusing glibc-linked binary in Termux archive' >&2 | ||
| exit 1 | ||
| fi | ||
| echo 'Cross-build: native Termux execution tests are a separate release gate' |
There was a problem hiding this comment.
Make the Termux runtime gate block publication
For every future published tag, the Android branch succeeds after static ELF checks and this informational echo; publish then depends only on binary/source and immediately uploads the archive. A repo-wide search found no native-Termux job or approval that gates that upload, so the exact binary built here cannot undergo the stated native smoke test before becoming public, allowing a linker-valid but nonfunctional Termux binary to ship. Add a blocking test or approval that validates this artifact before the publish job proceeds.
Useful? React with 👍 / 👎.
Purpose
Prepare next approved MCH release only with two additional, distinct ARM64 archives. The already published v0.2.1 release must remain unchanged.
Exact changes
ubuntu-22.04-arm) and Android Bionic ARM64 cross-build (aarch64-linux-android, NDK clang + llvm-ar). Verify ARM64 ELF architecture and Android/system/bin/linker64interpreter..github/workflows/release-packages.ymlwithlinux-aarch64andandroid-aarch64-termuxbinary artifacts, preserving all three original binaries and both source archives.SHA256SUMS.txt).Safety / provenance
48cb0268c436595674454623c9611ea10c4f56f1.Draft PR — do not auto-merge or run release-packages workflow against v0.2.1.
Verification performed
Public PR CI 39695866928 succeeded on all five jobs, including native Linux AArch64 and Android/Termux AArch64 cross-compile; the prior three-platform CI remains green. In private repo CI 39695806659 also passed both ARM64 targets. Its actual Android NDK-created ELF ran natively on AArch64 Termux, including verified copy, single-file resume, nested directory resume and restart recheck. The new release packaging workflow has not been run on a future release tag; archive publish and asset verification still require the next separately approved stable release and review. Public v0.2.1 assets remain untouched.