Skip to content

security: build release drafts before immutable publish - #10

Merged
Olize merged 2 commits into
mainfrom
security/immutable-release-workflow-20261022
Oct 22, 2026
Merged

Olize merged 2 commits into
mainfrom
security/immutable-release-workflow-20261022

Conversation

@Olize

@Olize Olize commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Addresses independent M4 audit. Repository immutable releases setting enabled via GitHub official endpoint on 2026-10-22. For v0.2.3+ only: trigger by new tag, deny historical and already-published releases, pin Rust 1.99.1, build all seven archives, generate checksums, upload only to empty draft without --clobber, verify eight uploaded GitHub SHA256 digests and then publish and assert immutable=true. Remove workflow_dispatch and release:published triggers. Add source policy regression check in CI. Does not change any application code, tags, or existing v0.2.2 release.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T12:52:24.515497Z 0297ca8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0297ca8b31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release-packages.yml Outdated
Comment thread .github/workflows/release-packages.yml
@Olize

Olize commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

Addressed both P1 review findings in 8e5ec89: (1) draft asset hashes now come from draft-aware gh release view GraphQL instead of published-only REST by-tag; (2) the remote tag object is peeled and compared against the exact verified build SHA both immediately before draft creation and immediately before publication. All six updated PR CI jobs passed. Resolving those threads as fixed, without bypassing branch protection.

@Olize
Olize merged commit 52cf665 into main Oct 22, 2026
6 checks passed
@Olize
Olize deleted the security/immutable-release-workflow-20261022 branch October 22, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant