Repository navigation
Audit N4: require exact missing WireGuard secret rejection in public source CI - #6
Merged
Merged
Conversation
…r than any process exit
Olize
marked this pull request as ready for review
October 22, 2026 00:33
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the independently protected public source-alpha test without changing application runtime code. Audit N4 found the existing
docker runnegative test treated any non-zero exit as PASS. The revised test supplies synthetic format-valid WireGuard address, relay address, port and public key but no private key secret, executes the isolated container with--network none --cap-drop=ALL, and requires preciselyERROR: WireGuard key secret missing.rather than an arbitrary crash. Build signature and source-only boundaries unchanged; no real secrets, GHCR push, dev/private links, release or production changes. Draft until mandatory publicsource-buildCI passes.