Repository navigation
Build every piece of the 39.07 mm dovetail plate, and name a piece that fails in Checks - #78
Merged
Merged
Conversation
…piece Every piece with a seam on its left threw in the seam repair and was never built. Two facets of the socket's sloped corner cross the counterbore's ceiling 2 microns from an edge of its own, which leaves three corners just over the weld distance apart, each within it of the line through the other two; the T-junction pass put them into each other's edges until it ran out of passes. When the passes run out, the repair now makes one point of the points it was still putting in that lie within two weld distances of each other, and runs once more. A repair that settles in its passes, which every one did across 1,100 random plates, is unchanged. Audit rows for the plate as filed and the edges of where it threw. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
A piece the engine threw on stopped the build and turned Download off, and the piece table and the preview said so, but the checks under the cut map said nothing. They now say which piece could not be built and what usually gets past it, drawn as an error, and the next build clears it. The page test forces a failure for that, since no design is known to throw now, and the plate from #76 is opened and has to build both pieces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
… as before The merge #76 added ran the repair once more and returned whatever that came to. A jigsaw plate at 41.24 mm with magnets from above and a 3.126 mm counterbore runs out of passes on both pieces, and the second run settles with edges open: the page built A1 and B1 with 55 bad edges each and Download on, where main fails A1 and says so. With a 2.264 mm magnet the pieces came out closed but folded, with NaN normals in the STL. The second run is now kept only if it comes out closed; otherwise it throws as before. plate-audit.js holds that plate and its 2.264 mm variant to "threw in the seam repair, or watertight and oriented", built as the page builds them, and the #76 rows are now checked for orientation as well as leaks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
…e that gets past it "The plates cannot be downloaded" overstated it: the pieces built before the one that failed keep their own STL buttons in the piece table. And "a size changed by a hundredth of a millimetre usually gets past it" can send someone to a size that builds with holes: the 41.24 mm jigsaw plate fails with a 7.504 mm head and builds with 57 bad edges a piece at 7.502 mm, on main too. The forced-failure spec's comment said no design was known to throw; that jigsaw plate does again, and the spec now reads the new wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Before #76's merge, the turned cutters of a cell cut again threw at healCsgSeams' pass limit on a few engine-only cells, the build passed the throw over, and the nudged try after it closed the cell. Now that try can settle after the merge, come back closed, and be kept, so "same bytes unless it threw" holds per cut, not per piece. The audit's "a retry that throws" is that case: the limit is reached ten times over its five pieces, every piece's bytes change, and every piece is still watertight and oriented. Its comment and the fastener cut's now say so, and that no audit row reaches the catch any more (traced over the whole audit: 19 merges, 2 throws, neither passed over). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
Only sw.js conflicted, on its VERSION line: taken from main and rebuilt with node build.js, which regenerated both pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XjNf7SQF9o4ZVeWiSbWQmk
3 tasks done
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
Only sw.js conflicted; the pages are rebuilt from the merged sources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
5 of 6 tasks
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
sw.js and plates-robustness.spec.js conflicted: the spec keeps #73's cases and takes main's comment and name for the failed-build case. The pages are rebuilt from the merged sources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
…for a counterbore's MOUNT_BORE.hole.turn looked at the magnet pocket's corners only once the counterbore's already called for a turn. So a shank no counterbore corner came near was cut unturned even with a magnet's corner on a flat's plane, and the BSP split there: the review's 41.24 mm jigsaw link, a 3 mm shank under a 7.3 mm magnet from above whose corner stands 0.4 microns off a flat, built both pieces with 26 open edges and Download on, where main fails to build. The magnet's corners now call for the turn as the counterbore's do. The link, its 2.264 mm magnet and the 7.4 mm head beside it build whole, and #78's rows keep their test, with the 7.4 mm head added. Heads 7.3 to 7.7, depths 3 to 3.25, magnets 2.15 to 2.35 thick and pitches 41.2 to 41.34 close, but for 7.31 mm, #77's coincidence. The turn moves none of the 3,846 one-cell plates or 1,800 designs it was measured on, and of 1,500 random designs it now turns, 54 close and 1 opens, at that one size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
Oliver-Johnson
pushed a commit
that referenced
this pull request
Oct 9, 2026
…1.24 mm link builds With its shank turned, the review's 41.24 mm jigsaw link no longer runs out of passes here, so #78's rows build whole and no longer reach the second run's guard. A fourth row cuts main's bores for it, 7.504 cos(pi/14) and 3 cos(pi/12), which still run out of passes and throw, here as on main. The comments that said the plate fails here now say where it still does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Oliver · project thread
What this changes
Closes #76.
Before.
After.
How.
healCsgSeamsdoes something new only when it runs out of passes.healCsgSeamsis shared with the Bins page, so bins/index.html is rebuilt too; the Bins audit is clean. No new top-level names.Checks
src/, not the generatedindex.html/bins/index.htmlnode build.jsand committed the regenerated pages alongside the sourcesnpm run test:allpasses (run here:npm test, ci-sim, and the plate UI specs, 166 passed; not the whole UI suite)If this touches geometry
node test/bin-audit.jsreportsall cases cleannode test/plate-audit.jsreportsall plates watertight, and no case has picked up bad edges that were not already named as knownThe page tests: a new case opens the #76 link and needs "2 ready" with Download on, and the stubbed-failure case checks that Checks names the piece, says Download is off, and that the next build clears it. Both fail on the old page.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqqb1cvhXxrpb3P6y6ykBY