Repository navigation
Fix byte-safe memo truncation edge case in Stellar memo handling - #1276
Merged
Merged
Conversation
Refactor UTF-8 decoding logic and clean up SVG path data.
|
@Biokes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a narrow edge case in
truncateMemoToStellarLimitwhere a memo could still receive a spurious Unicode replacement character (�) after truncation.Previously, the safety check for a broken UTF-8 boundary was gated on whether the original input already contained a replacement character. That meant a memo that legitimately contained
�before the truncation cut point could bypass the guard, and in a rare case the truncated byte tail could still re-encode to the same byte length while injecting an extra replacement character.This patch removes that extra condition and relies only on the byte round-trip-length check to detect a broken truncation boundary.
File changed
frontend/src/components/support-panel.tsxWhat changed
truncateMemoToStellarLimitso it detects invalid truncation boundaries based solely on whether the decoded output still round-trips to the same byte length.!input.includes("�").Closes #1238
Closes #1239
Closes #1240
Closes #1241