Repository navigation
docs(bindings): changelog entry for the Wi-Fi Direct enable fix - #698
Merged
Merged
Conversation
#686 fixed two things. Enabling Wi-Fi Direct stopped the manager only while RUNNING, which shipped in 0.31.0, so it gets an entry. The stranded listener after a throw, and #683's bind-before-STARTING and accept timeout fixes, all repair code #681 added after 0.31.0, so they reached no user and get one clause on #681's entry instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readiness check for 0.32.0 found two merged fixes with no entry under Unreleased: #686 and #683. Only one of their four items fixed behaviour that shipped, so this adds one entry and one clause.
What shipped in 0.31.0, and gets an entry
#686, item 2. In v0.31.0, the Wi-Fi Direct branch of
ProtocolEngineHost.enableTransportstopped the manager only when it wasRUNNING. The Internet branch also stopped it when it wasSTARTING. An enable that found a start in progress started it again over the first one. The new entry under Fixed describes this.What never shipped, and gets no entry
StartFailedthrow after STARTING was added by fix(bindings): a second SDK app on an Android phone gets its own LAN streams #681. v0.31.0 has noStartFailedinWifiDirectManager.ktand binds asynchronously instartServerSocket.Instead, #681's entry gains one clause: a start that fails at any point leaves nothing running. That is true on main, because the bind comes before STARTING and any throw after it runs
stopUnsafe()and closes the listener.Verification
git show v0.31.0:of both files. TheSTARTINGgap is atProtocolEngineHost.ktin thewifidirectbranch.StartFailedinWifiDirectManager.kt: 0 at v0.31.0, 1 at fix(bindings): a second SDK app on an Android phone gets its own LAN streams #681, 2 at fix(bindings): finish the shared-network phase 0 review items #683.enableTransport("wifiDirect")inbindings/react-native/src/index.ts.