Skip to content

Calamari may hang on Windows when process crashes or is killed #10242

Description

@xwipeoutx

Prerequisites

  • I have searched open and closed issues to make sure it isn't already requested
  • My team has started working on this issue
  • I have written a descriptive issue title

The enhancement

The Need

On Windows, Calamari keeps a machine-wide lock for a Semaphore. A Semaphore on windows does not relinquish control to the next waiter when the process is killed, which means the lock is held indefinitely.

Solution

Switch it so Windows uses a Mutex instead. Add extra logging so the hang is easier to diagnose.

Screenshots and Mockups

N/A

Links

Calamari PR

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

kind/enhancementThis issue represents an enhancement we are committed to adding to Octopus as some time

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions