Skip to content

Add logging to track down why Calamari hangs when running clean packages #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LukeButters wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

Add logging to track down why Calamari hangs when running clean packages #2156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c3ec7
Add logging to track down why Calamari hangs when running clean packages
LukeButters Sep 14, 2026
e335d14
.
LukeButters Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/Calamari.Common/Features/Processes/ScriptIsolation/LockOptionsResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public sealed class LockOptionsResolver(
{
public LockOptions? Create(RequestedLockOptions requestedOptions)
{
log.Verbose($"Creating lock for lock options: {requestedOptions.Type} {requestedOptions.MutexName}");
var lockDirectory = lockDirectoryFactory.Create(requestedOptions.PreferredLockDirectory);

var lockFile = lockDirectory.GetLockFile($"ScriptIsolation.{requestedOptions.MutexName}.lock");
Expand Down
2 changes: 2 additions & 0 deletions source/Calamari.Common/Features/Processes/Semaphores/SystemSemaphoreManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ IDisposable AcquireMutex(string name, string waitMessage)
[SupportedOSPlatform("windows")]
void SetFullAccessControlForAllUsers(Semaphore semaphore, string name)
{
log.Verbose($"Setting full control for all users on semaphore '{name}'");
var semaphoreSecurity = new SemaphoreSecurity();
var everyone = new SecurityIdentifier(WellKnownSidType.WorldSid, null);
var rule = new SemaphoreAccessRule(everyone, SemaphoreRights.FullControl, AccessControlType.Allow);
Expand All @@ -120,6 +121,7 @@ void SetFullAccessControlForAllUsers(Semaphore semaphore, string name)
try
{
semaphore.SetAccessControl(semaphoreSecurity);
log.Verbose($"Set full control for all users on semaphore '{name}'");
}
catch (Exception e)
{
Expand Down
2 changes: 2 additions & 0 deletions source/Calamari/Deployment/PackageRetention/Model/PackageJournal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,10 @@ public void ApplyRetention()
{
try
{
log.Verbose("Acquiring semaphore before applying package retention.");
using (AcquireSemaphore())
{
log.Verbose("Loading journal and applying retention.");
journalRepository.Load();
var packagesToRemove = retentionAlgorithms.SelectMany(algorithm => algorithm.GetPackagesToRemove(journalRepository.GetAllJournalEntries()));
foreach (var package in packagesToRemove)
Expand Down