Add ArgoCD Step annotation support - #2153
Open
liam-mackie wants to merge 4 commits into
Open
liam-mackie wants to merge 4 commits into
liam-mackie wants to merge 4 commits into
Conversation
flin-8
reviewed
Sep 7, 2026
| namespace Calamari.ArgoCD; | ||
|
|
||
| public record DeploymentScope(ProjectSlug Project, EnvironmentSlug Environment, TenantSlug? Tenant) | ||
| public record DeploymentScope(ProjectSlug Project, EnvironmentSlug Environment, TenantSlug? Tenant, StepSlug? Step = null) |
Contributor
Author
There was a problem hiding this comment.
Originally, the step scope was behind a toggle, so it could be, but I spoke to Rob and we decided against a feature toggle (it would have been super confusing to roll forward/back, and isn't really a reversible decision). I don't think there's any cases where it's nullable now, so I'll look at pulling that back out.
Contributor
Author
There was a problem hiding this comment.
Taking a look, there's a possibility of the step slug being null only if the process was persisted before slugs, and never edited and saved again. Since Argo steps got released after slugs, this is indeed a nonexistent problem :D
zentron
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for an optional step annotation for ArgoCD applications. By default, with no step annotations, any step may act on the application/source.