Skip to content

Let dotnet-script roll forward to a newer .NET runtime #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NickJosevski wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Let dotnet-script roll forward to a newer .NET runtime #2095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion source/Calamari.Common/Features/Scripting/DotnetScript/DotnetScriptExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ namespace Calamari.Common.Features.Scripting.DotnetScript
{
public class DotnetScriptExecutor : ScriptExecutor
{
const string DotnetRollForwardVariableName = "DOTNET_ROLL_FORWARD";

readonly ICommandLineRunner commandLineRunner;

public DotnetScriptExecutor(ICommandLineRunner commandLineRunner, ILog log): base(log)
Expand All @@ -37,13 +39,37 @@ protected override IEnumerable<ScriptExecution> PrepareExecution(Script script,
bool.TryParse(variables.Get("Octopus.Action.Script.CSharp.BypassIsolation", "false"), out var bypassDotnetScriptIsolation);

var cli = CreateCommandLineInvocation(executable, arguments, !string.IsNullOrWhiteSpace(localDotnetScriptPath));
cli.EnvironmentVars = environmentVars;
cli.EnvironmentVars = WithDotnetRollForward(environmentVars);
cli.WorkingDirectory = workingDirectory;
cli.Isolate = !bypassDotnetScriptIsolation;

yield return new ScriptExecution(cli, otherTemporaryFiles.Concat(new[] { bootstrapFile, configurationFile }));
}

/// <summary>
/// dotnet-script is a framework-dependent application - the bundled copy targets
/// Microsoft.NETCore.App 8.0.0. By default a framework-dependent app will not roll forward
/// across a major version, so on a machine that only has a newer runtime installed it fails
/// to launch with "You must install or update .NET to run this application".
///
/// Calamari itself is published self-contained and carries no such requirement; this affects
/// only the separate dotnet-script process. Setting DOTNET_ROLL_FORWARD=Major lets it run on
/// whatever newer runtime is present, so C# script steps don't additionally require the exact
/// runtime dotnet-script was built against.
/// </summary>
static Dictionary<string, string> WithDotnetRollForward(Dictionary<string, string>? environmentVars)

@APErebus APErebus Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DotNet script requires the dotnet sdk, not just the dotnet runtime, does this work for that?

{
var vars = environmentVars == null
? new Dictionary<string, string>()
: new Dictionary<string, string>(environmentVars);

// Don't override an explicit value - the surrounding environment may have set one deliberately.
if (!vars.ContainsKey(DotnetRollForwardVariableName))
vars[DotnetRollForwardVariableName] = "Major";

return vars;
}

private string GetExecutable(string? localDotnetScriptPath, string bundledExecutable)
{
return string.IsNullOrWhiteSpace(localDotnetScriptPath)
Expand Down