Repository navigation
Splash: reapply_text reconciles host-generated UI into existing widgets - #35
Merged
Merged
Conversation
A host that regenerates a Splash body from declarative data (Rinx's L0 mini apps) must keep focus, selection and scroll state in the named widgets it already has. reapply_text evaluates the new body with Apply::Reload into the existing view; set_text still tears the instance down. From #32 (its Splash part), on main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Splash part of #32, on current
main(d0a9def5). This is the API Rinx's native mini-app host needs to run inside OctoSense shells at the current runtime.SplashRef::reapply_text(cx, body)evaluates a regenerated body withApply::Reloadinto the existing view, so named widgets keep their Rust state (focus, selection, scroll) while declarative data changes.set_text("")still tears the instance down and revokes callbacks. The main VM and empty bodies fall back toset_text. The change is additive; no existing caller changes behavior.Not included: #32's Android Back changes (double Back delivery,
OnBackInvokedCallback, the application-extension meta-data). Back handling in ROM Home is being reworked separately, so that part stays with #32 or its successor.Validation:
cargo check -p makepad-widgetspasses. ROM Home'spatches/runtime/makepad-settings.patchstill applies to this base (git apply --check). Rinx's mini-app screen compiles against it (hagency-org/Rinx#25 follow-up).🤖 Generated with Claude Code